]> git.ipfire.org Git - thirdparty/libvirt.git/commit
virSetUIDGIDWithCaps: Set bounding capabilities only with CAP_SETPCAP
authorMichal Privoznik <mprivozn@redhat.com>
Thu, 22 Jul 2021 12:26:00 +0000 (14:26 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 26 Jul 2021 07:54:40 +0000 (09:54 +0200)
commita2476f37a7789eb9315b77bb451f4754ef4ef15b
tree5fc6e467f7c94c21ae688dec83598f37a5865945
parentb69affe3c1df8302300d6622ab747c9bef854d8f
virSetUIDGIDWithCaps: Set bounding capabilities only with CAP_SETPCAP

In one of my previous patches I've tried to postpone dropping
CAP_SETPCAP until the very end because it's needed for
capng_apply(). What I did not realize back then was that we might
not have the capability to begin with. Because of unknown reasons
capng_apply() pollutes logs only for CAPNG_SELECT_BOUNDS and not
for CAPNG_SELECT_CAPS.

Reproducer is really simple: run libvirtd as a regular user.
During its initialization, libvirtd will spawn some binaries
(dnsmasq, qemu-*, etc.) and while doing so it will try to drop
capabilities.

Anyway, let's call capng_apply(CAPNG_SELECT_BOUNDS) only if we
have the CAP_SETPCAP (which is tracked in need_setpcap variable).

Fixes: 438b50dda8a863fdc988e9ab612f097cc1626e8a
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1924218
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Cole Robinson <crobinso@redhat.com>
src/util/virutil.c