]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: ethernet: bgmac-platform: fix an OF node reference leak
authorJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Sat, 14 Dec 2024 01:49:12 +0000 (10:49 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jan 2025 12:24:52 +0000 (13:24 +0100)
commita24ce83a2de11575d8b80e4951065a4219ea6e5d
tree1ecb13d47bab10e06c4d8427aa4db4117d0331f7
parent1942218bf95ff2a4dc6ad76bac93446561846a28
net: ethernet: bgmac-platform: fix an OF node reference leak

[ Upstream commit 0cb2c504d79e7caa3abade3f466750c82ad26f01 ]

The OF node obtained by of_parse_phandle() is not freed. Call
of_node_put() to balance the refcount.

This bug was found by an experimental static analysis tool that I am
developing.

Fixes: 1676aba5ef7e ("net: ethernet: bgmac: device tree phy enablement")
Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20241214014912.2810315-1-joe@pf.is.s.u-tokyo.ac.jp
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/broadcom/bgmac-platform.c