]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
efi/cper: Fix cper_bits_to_str buffer handling and return value
authorMorduan Zang <zhangdandan@uniontech.com>
Wed, 14 Jan 2026 05:30:33 +0000 (13:30 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 Jan 2026 10:21:12 +0000 (11:21 +0100)
commita2542fe353a40b9b03bffdcedc64107ac9322aab
tree1e55614ebd45fcf556021f15cd068f95c627f867
parent58796d352d74669eacc4715e0901949e9e66f770
efi/cper: Fix cper_bits_to_str buffer handling and return value

commit d7f1b4bdc7108be1b178e1617b5f45c8918e88d7 upstream.

The return value calculation was incorrect: `return len - buf_size;`
Initially `len = buf_size`, then `len` decreases with each operation.
This results in a negative return value on success.

Fix by returning `buf_size - len` which correctly calculates the actual
number of bytes written.

Fixes: a976d790f494 ("efi/cper: Add a new helper function to print bitmasks")
Signed-off-by: Morduan Zang <zhangdandan@uniontech.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/firmware/efi/cper.c