]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
media: mc: fix potential use-after-free in media_request_alloc()
authorMathias Krause <minipli@grsecurity.net>
Tue, 9 Dec 2025 21:09:03 +0000 (22:09 +0100)
committerChristian Brauner <brauner@kernel.org>
Mon, 15 Dec 2025 14:12:28 +0000 (15:12 +0100)
commita260bd22a355bcdb74cedac6ab9b10739cd2c62c
tree10fe197ba2ae6c1c1c2756c7a9671ae571a67d8b
parent8f0b4cce4481fb22653697cced8d0d04027cb1e8
media: mc: fix potential use-after-free in media_request_alloc()

Commit 6f504cbf108a ("media: convert media_request_alloc() to
FD_PREPARE()") moved the call to fd_install() (now hidden in
fd_publish()) before the snprintf(), making the later write to
potentially already freed memory, as userland is free to call
close() concurrently right after the call to fd_install() which
may end up in the request_fops.release() handler freeing 'req'.

Fixes: 6f504cbf108a ("media: convert media_request_alloc() to FD_PREPARE()")
Signed-off-by: Mathias Krause <minipli@grsecurity.net>
Link: https://patch.msgid.link/20251209210903.603958-1-minipli@grsecurity.net
Signed-off-by: Christian Brauner <brauner@kernel.org>
drivers/media/mc/mc-request.c