]> git.ipfire.org Git - thirdparty/openssl.git/commit
Fix Coverity issue in kdf_snmpkdf_set_ctx_params
authorNeil Horman <nhorman@openssl.org>
Mon, 15 Dec 2025 14:04:54 +0000 (09:04 -0500)
committerNorbert Pocs <norbertp@openssl.org>
Wed, 17 Dec 2025 12:45:22 +0000 (13:45 +0100)
commita28accadf709afbc3b29343fccde0304ab541884
treeb4d5b6abafa855db7a1c1bc320e6e3b4173b338e
parent473dff4781780abd43fc789b1a36d65c3c383ba8
Fix Coverity issue in kdf_snmpkdf_set_ctx_params

Coverity flagged a use before NULL check error in
kdf_snmpkdf_set_ctx_params.

In this function the ctx pointer was dereferenced to obtain a
OSSL_LIB_CTX pointer, and only after that dereference was ctx checked
for being NULL.

fix is pretty clear, just move the OSSL_LIB_CTX computation down to a
point after ctx is checked for NULL.

fixes openssl/project#1765

Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Norbert Pocs <norbertp@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29400)
providers/implementations/kdfs/snmpkdf.c