]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tracing: Do not add event files for modules that fail tracepoints
authorSteven Rostedt (Red Hat) <rostedt@goodmis.org>
Wed, 26 Feb 2014 18:37:38 +0000 (13:37 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Mar 2014 04:37:06 +0000 (21:37 -0700)
commita299804140325db7b93173419b0724056b60f34d
treebd83dcad3466c51e0f3a731ec15b5b09be562814
parentc5ad4fdec0ae15d197508185643c68470868121d
tracing: Do not add event files for modules that fail tracepoints

commit 45ab2813d40d88fc575e753c38478de242d03f88 upstream.

If a module fails to add its tracepoints due to module tainting, do not
create the module event infrastructure in the debugfs directory. As the events
will not work and worse yet, they will silently fail, making the user wonder
why the events they enable do not display anything.

Having a warning on module load and the events not visible to the users
will make the cause of the problem much clearer.

Link: http://lkml.kernel.org/r/20140227154923.265882695@goodmis.org
Fixes: 6d723736e472 "tracing/events: add support for modules to TRACE_EVENT"
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/tracepoint.h
kernel/trace/trace_events.c
kernel/tracepoint.c