]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
selftests: pmtu: use -oneline for ip route list cache
authorThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Thu, 28 Nov 2019 18:58:06 +0000 (15:58 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Dec 2019 21:34:28 +0000 (22:34 +0100)
commita2e1484ed6dc5bca7defdfdb97818bcb9fc69e6a
tree7691fd127e1dad0691a38f6d8c938b2b39c41e61
parent8fc720c8cb0e782f26a89f8241a12e0e04256c89
selftests: pmtu: use -oneline for ip route list cache

[ Upstream commit 2745aea6750ff0d2c48285d25bdb00e5b636ec8b ]

Some versions of iproute2 will output more than one line per entry, which
will cause the test to fail, like:

TEST: ipv6: list and flush cached exceptions                        [FAIL]
  can't list cached exceptions

That happens, for example, with iproute2 4.15.0. When using the -oneline
option, this will work just fine:

TEST: ipv6: list and flush cached exceptions                        [ OK ]

This also works just fine with a more recent version of iproute2, like
5.4.0.

For some reason, two lines are printed for the IPv4 test no matter what
version of iproute2 is used. Use the same -oneline parameter there instead
of counting the lines twice.

Fixes: b964641e9925 ("selftests: pmtu: Make list_flush_ipv6_exception test more demanding")
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Acked-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/testing/selftests/net/pmtu.sh