]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Fix error message about extended errors for IPv4-only sockets.
authorGert Doering <gert@greenie.muc.de>
Sat, 23 Jul 2022 12:19:09 +0000 (14:19 +0200)
committerGert Doering <gert@greenie.muc.de>
Mon, 25 Jul 2022 15:27:06 +0000 (17:27 +0200)
commita2e63fb978b7497ebc7e8ec56504fd2300f97621
tree66e6f7d88cdeb27162cbd2d65b9ff07a422b2cdb
parent95afd63ac74197980ecff2b3ecb2116d62035f7f
Fix error message about extended errors for IPv4-only sockets.

The new code to enable IPv6 extended error reporting will cause
an error ("Protocol not available (errno=92)") if trying to enable
that setsockopt() option on an IPv4-only socket.

Fix: pass sock->info.af to set_sock_extended_error_passing(), only
apply to AF_INET6 sockets.

To make that work, ensure that sock->info.af is set to not only
the value coming from config (which might be AF_UNSPEC) but to the
actual value used in socket creation (credits: Arne Schwabe).

Add comments to make explicit that the asymmetry here (IPv4 extended
socket error reporting is enabled on all sockets) is intentional.

Signed-off-by: Gert Doering <gert@greenie.muc.de>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Message-Id: <20220723121909.21943-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24731.html

Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/mtu.c
src/openvpn/mtu.h
src/openvpn/socket.c