]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
pcmcia: fix setting of kthread task states
authorDominik Brodowski <linux@dominikbrodowski.net>
Sun, 9 Jan 2022 09:02:51 +0000 (10:02 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 07:47:35 +0000 (08:47 +0100)
commita328c29bc84507c66f80a89ce7fefe882dbfbdde
tree175244e615106a01b59c8921545fddf3e0e7a945
parentf5e5b20d8faca299f387b37465b53e5190291015
pcmcia: fix setting of kthread task states

[ Upstream commit fbb3485f1f931102d8ba606f1c28123f5b48afa3 ]

We need to set TASK_INTERRUPTIBLE before calling kthread_should_stop().
Otherwise, kthread_stop() might see that the pccardd thread is still
in TASK_RUNNING state and fail to wake it up.

Additionally, we only need to set the state back to TASK_RUNNING if
kthread_should_stop() breaks the loop.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reported-by: Al Viro <viro@ZenIV.linux.org.uk>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Fixes: d3046ba809ce ("pcmcia: fix a boot time warning in pcmcia cs code")
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pcmcia/cs.c