]> git.ipfire.org Git - thirdparty/linux.git/commit
selftests/bpf: Fix resource leak in serial_test_wq on attach failure
authorKery Qi <qikeyu2017@gmail.com>
Wed, 21 Jan 2026 09:41:16 +0000 (17:41 +0800)
committerAndrii Nakryiko <andrii@kernel.org>
Thu, 22 Jan 2026 00:12:10 +0000 (16:12 -0800)
commita32ae2658471dd87a2f7a438388ed7d9a5767212
tree89c4235e1074d2b7a35113a1081ae2864052bd03
parent26ad5d6e763070aa146d86b941884b11eb1ac0aa
selftests/bpf: Fix resource leak in serial_test_wq on attach failure

When wq__attach() fails, serial_test_wq() returns early without calling
wq__destroy(), leaking the skeleton resources allocated by
wq__open_and_load(). This causes ASAN leak reports in selftests runs.

Fix this by jumping to a common clean_up label that calls wq__destroy()
on all exit paths after successful open_and_load.

Note that the early return after wq__open_and_load() failure is correct
and doesn't need fixing, since that function returns NULL on failure
(after internally cleaning up any partial allocations).

Fixes: 8290dba51910 ("selftests/bpf: wq: add bpf_wq_start() checks")
Signed-off-by: Kery Qi <qikeyu2017@gmail.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
Link: https://lore.kernel.org/bpf/20260121094114.1801-3-qikeyu2017@gmail.com
tools/testing/selftests/bpf/prog_tests/wq.c