]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/xe/sa: Always call drm_suballoc_manager_fini()
authorMichal Wajdeczko <michal.wajdeczko@intel.com>
Fri, 20 Dec 2024 19:41:54 +0000 (20:41 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 May 2025 09:13:46 +0000 (11:13 +0200)
commita3547adcc64e46e064a3b3dc0db3b842cf1895fe
tree5f33dae9eeaca0fd9c91c16ac945b18e575b5e3c
parent28f395311113dbad9f24b630e8b319742c322743
drm/xe/sa: Always call drm_suballoc_manager_fini()

[ Upstream commit 9cd3f4efc870463f17f6c29114c61fb6bfcaa291 ]

After successful call to drm_suballoc_manager_init() we should
make sure to call drm_suballoc_manager_fini() as it may include
some cleanup code even if we didn't start using it for real.

As we can abort init() early due to kvzalloc() failure, we should
either explicitly call drm_suballoc_manager_fini() or, even better,
postpone drm_suballoc_manager_init() once we finish all other
preparation steps, so we can rely on fini() that will do cleanup.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241220194205.995-2-michal.wajdeczko@intel.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/xe/xe_sa.c