]> git.ipfire.org Git - thirdparty/linux.git/commit
cxl/features: Add check for no entries in cxl_feature_info
authorDave Jiang <dave.jiang@intel.com>
Thu, 9 Oct 2025 15:40:01 +0000 (08:40 -0700)
committerDave Jiang <dave.jiang@intel.com>
Mon, 13 Oct 2025 20:47:49 +0000 (13:47 -0700)
commita375246fcf2bbdaeb1df7fa7ee5a8b884a89085e
tree8b0a0bdbc4e53a8230d4f10bc22f06d9793962d3
parent02e7567f5da023524476053a38c54f4f19130959
cxl/features: Add check for no entries in cxl_feature_info

cxl EDAC calls cxl_feature_info() to get the feature information and
if the hardware has no Features support, cxlfs may be passed in as
NULL.

[   51.957498] BUG: kernel NULL pointer dereference, address: 0000000000000008
[   51.965571] #PF: supervisor read access in kernel mode
[   51.971559] #PF: error_code(0x0000) - not-present page
[   51.977542] PGD 17e4f6067 P4D 0
[   51.981384] Oops: Oops: 0000 [#1] SMP NOPTI
[   51.986300] CPU: 49 UID: 0 PID: 3782 Comm: systemd-udevd Not tainted 6.17.0dj
test+ #64 PREEMPT(voluntary)
[   51.997355] Hardware name: <removed>
[   52.009790] RIP: 0010:cxl_feature_info+0xa/0x80 [cxl_core]

Add a check for cxlfs before dereferencing it and return -EOPNOTSUPP if
there is no cxlfs created due to no hardware support.

Fixes: eb5dfcb9e36d ("cxl: Add support to handle user feature commands for set feature")
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
drivers/cxl/core/features.c