]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
KEYS: prevent NULL pointer dereference in find_asymmetric_key()
authorRoman Smirnov <r.smirnov@omp.ru>
Tue, 17 Sep 2024 15:54:53 +0000 (18:54 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Oct 2024 14:29:48 +0000 (16:29 +0200)
commita3765b497a4f5224cb2f7a6a2d3357d3066214ee
tree6d7eb8147f55ec2afb7cf264e4fb7b0b973034cc
parentc886061bbdd1f37190939b11926055413e86a56c
KEYS: prevent NULL pointer dereference in find_asymmetric_key()

commit 70fd1966c93bf3bfe3fe6d753eb3d83a76597eef upstream.

In find_asymmetric_key(), if all NULLs are passed in the id_{0,1,2}
arguments, the kernel will first emit WARN but then have an oops
because id_2 gets dereferenced anyway.

Add the missing id_2 check and move WARN_ON() to the final else branch
to avoid duplicate NULL checks.

Found by Linux Verification Center (linuxtesting.org) with Svace static
analysis tool.

Cc: stable@vger.kernel.org # v5.17+
Fixes: 7d30198ee24f ("keys: X.509 public key issuer lookup without AKID")
Suggested-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Roman Smirnov <r.smirnov@omp.ru>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
crypto/asymmetric_keys/asymmetric_type.c