]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tcp: md5: do not use alloc_percpu()
authorEric Dumazet <edumazet@google.com>
Thu, 23 Oct 2014 19:58:58 +0000 (12:58 -0700)
committerJiri Slaby <jslaby@suse.cz>
Wed, 5 Nov 2014 09:03:22 +0000 (10:03 +0100)
commita388cd772c2e0cd19f61a3b0dc8d2ecd6b380216
tree7d4188095fef231399b259cccaa9884f1ee27120
parent93b6d31fdc9b3b4ee3f6544c18ad48aefeb54ce0
tcp: md5: do not use alloc_percpu()

[ Upstream commit 349ce993ac706869d553a1816426d3a4bfda02b1 ]

percpu tcp_md5sig_pool contains memory blobs that ultimately
go through sg_set_buf().

-> sg_set_page(sg, virt_to_page(buf), buflen, offset_in_page(buf));

This requires that whole area is in a physically contiguous portion
of memory. And that @buf is not backed by vmalloc().

Given that alloc_percpu() can use vmalloc() areas, this does not
fit the requirements.

Replace alloc_percpu() by a static DEFINE_PER_CPU() as tcp_md5sig_pool
is small anyway, there is no gain to dynamically allocate it.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Fixes: 765cf9976e93 ("tcp: md5: remove one indirection level in tcp_md5sig_pool")
Reported-by: Crestez Dan Leonard <cdleonard@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp.c