]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: Need to check for machine.os when using ADDRESS_TYPE_CCW
authorJohn Ferlan <jferlan@redhat.com>
Mon, 31 Aug 2015 15:06:42 +0000 (11:06 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Fri, 4 Sep 2015 12:47:33 +0000 (08:47 -0400)
commita39ab909081ab126990ca705852d38ff056b8f13
treefaa6239b061eba3c2105b32aa12e43fdfc0ca549
parentd334c91751c8eea33abe8e92761433a145e38112
qemu: Need to check for machine.os when using ADDRESS_TYPE_CCW

https://bugzilla.redhat.com/show_bug.cgi?id=1258361

When attaching a disk, controller, or rng using an address type ccw
or s390, we need to ensure the support is provided by both the machine.os
and the emulator capabilities (corollary to unconditional setting when
address was not provided for the correct machine.os and emulator.

For an inactive guest, an addition followed by a start would cause the
startup to fail after qemu_command builds the command line and attempts
to start the guest. For an active guest, libvirtd would crash.
src/qemu/qemu_command.c
src/qemu/qemu_command.h
src/qemu/qemu_hotplug.c