]> git.ipfire.org Git - thirdparty/openvpn.git/commit
verb 5 logging wrongly reports received bytes
authorDavid Sommerseth <dazo@users.sourceforge.net>
Fri, 19 Feb 2010 16:32:56 +0000 (17:32 +0100)
committerDavid Sommerseth <dazo@users.sourceforge.net>
Thu, 1 Apr 2010 21:15:36 +0000 (23:15 +0200)
commita3ff848b2909138ce053accec35b7a7a56b32487
tree42beceee090de5c9d13daa8992e265d00d141f19
parentc3b2faa737ad0f860f985a5ec7cea01d144fe933
verb 5 logging wrongly reports received bytes

With --verb 5, openvpn logs a single letter (rwRW) for each package
received or sent. I recently ran into a problem with the tun device on
Linux where the read from that device returned 0. Unfortunately this was
also logged as "r", which made me assume that openvpn had received
something, while it actually hadn't.

(See https://dev.openwrt.org/ticket/6650 for the bug that made me find out
about this problem with openvpn.)

I'm attaching a patch which prevents openvpn from logging "r" or "R" when
it didn't actually read anything. This is against openvpn 2.1-rc20, but
probably still applies to the most recent version.

This patch was received anonymously via the sf.net bug tracker:
<http://sourceforge.net/tracker/?func=detail&atid=454719&aid=2951003&group_id=48978>

Signed-off-by: David Sommerseth <dazo@users.sourceforge.net>
Acked-by: David Sommerseth <dazo@users.sourceforge.net>
Acked-by: Gert Doering <gert@greenie.muc.de>
forward.c