]> git.ipfire.org Git - thirdparty/asterisk.git/commit
chan_sip: chan_sip does not process 400 response to an INVITE.
authorFrederic LE FOLL <frederic.lefoll@c-s.fr>
Mon, 22 Jun 2020 09:08:47 +0000 (11:08 +0200)
committerGeorge Joseph <gjoseph@digium.com>
Thu, 25 Jun 2020 14:47:08 +0000 (09:47 -0500)
commita423f935c91788050595f2fd9521b9faf9ad9267
tree152e589da5e7e408fea6ac6d3648cea76a6cb2bf
parent8b925fbda3776a9533b4077e059a6fa1565f12ba
chan_sip: chan_sip does not process 400 response to an INVITE.

chan_sip handle_response() function, for a 400 response to an INVITE,
calls handle_response_invite() and does not generate ACK.
handle_response_invite() does not recognize 400 response and has no
default response processing for unexpected responses, thus it does not
generate ACK either.
The ACK on response repetition comes from handle_response() mechanism
"We must re-send ACKs to re-transmitted final responses".

According to code history, 400 response specific processing was
introduced with commit
"channels/chan_sip: Add improved support for 4xx error codes"
This commit added support for :
- 400/414/493 in handle_response_subscribe() handle_response_register()
  and handle_response().
- 414/493 only in handle_response_invite().

This fix adds 400 response support in handle_response_invite().

ASTERISK-28957

Change-Id: Ic71a087e5398dfc7273946b9ec6f9a36960218ad
channels/chan_sip.c