]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
arm64: bpf: fix signedness bug in loading 64-bit immediate
authorXi Wang <xi.wang@gmail.com>
Fri, 8 May 2015 05:39:51 +0000 (06:39 +0100)
committerSasha Levin <sasha.levin@oracle.com>
Wed, 10 Jun 2015 17:42:27 +0000 (13:42 -0400)
commita45b402bb2ec47fcb140d86098f035382680a31d
treec380bd28916ee3c794331a7847c8233fe4f9ebfd
parent748e016cf59aef21d02d1ba7ff2a337d616c83c7
arm64: bpf: fix signedness bug in loading 64-bit immediate

[ Upstream commit 1e4df6b7208140f3c49f316d33a409d3a161f350 ]

Consider "(u64)insn1.imm << 32 | imm" in the arm64 JIT.  Since imm is
signed 32-bit, it is sign-extended to 64-bit, losing the high 32 bits.
The fix is to convert imm to u32 first, which will be zero-extended to
u64 implicitly.

Cc: Zi Shen Lim <zlim.lnx@gmail.com>
Cc: Alexei Starovoitov <ast@plumgrid.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: <stable@vger.kernel.org>
Fixes: 30d3d94cc3d5 ("arm64: bpf: add 'load 64-bit immediate' instruction")
Signed-off-by: Xi Wang <xi.wang@gmail.com>
[will: removed non-arm64 bits and redundant casting]
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
arch/arm64/net/bpf_jit_comp.c