]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ANDROID: binder: remove waitqueue when thread exits.
authorMartijn Coenen <maco@android.com>
Fri, 5 Jan 2018 10:27:07 +0000 (11:27 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 7 Oct 2019 16:53:19 +0000 (18:53 +0200)
commita494a71146a1cf3f48bb94cf33981db1f027e6a0
treedcfbbf7cc31f6e3b3b1bf1cdbb70d80a36e081dc
parent198d33ad87d963a85e425bd2b9d6e8cb4e4c48f3
ANDROID: binder: remove waitqueue when thread exits.

commit f5cb779ba16334b45ba8946d6bfa6d9834d1527f upstream.

binder_poll() passes the thread->wait waitqueue that
can be slept on for work. When a thread that uses
epoll explicitly exits using BINDER_THREAD_EXIT,
the waitqueue is freed, but it is never removed
from the corresponding epoll data structure. When
the process subsequently exits, the epoll cleanup
code tries to access the waitlist, which results in
a use-after-free.

Prevent this by using POLLFREE when the thread exits.

Signed-off-by: Martijn Coenen <maco@android.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Cc: stable <stable@vger.kernel.org> # 4.14
[backport BINDER_LOOPER_STATE_POLL logic as well]
Signed-off-by: Mattias Nissler <mnissler@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/android/binder.c