]> git.ipfire.org Git - thirdparty/squid.git/commit
Honor on_unsupported_protocol for intercepted https_port (#689)
authorAlex Rousskov <rousskov@measurement-factory.com>
Mon, 6 Jul 2020 08:04:31 +0000 (08:04 +0000)
committerAmos Jeffries <yadij@users.noreply.github.com>
Tue, 11 Aug 2020 05:13:21 +0000 (17:13 +1200)
commita4c1596dd5b05937dca44a8e7aa8dcd289bf3905
tree4894661065a99e6bee928c8e80a3d19f06d55547
parentf7a315f4277c8b6b427732a0e5b5d1398af305d2
Honor on_unsupported_protocol for intercepted https_port (#689)

... when Squid discovers a non-TLS client while parsing its handshake.

For https_port traffic, ConnStateData::switchToHttps() relies on start()
to set preservingClientData_ correctly, but shouldPreserveClientData(),
called by start() to set preservingClientData_, was not preserving TLS
bytes in the https_port start() context. Typical debug messages:

    parseTlsHandshake: Got something other than TLS ... Cannot SslBump
    tunnelOnError: may have forgotten client data; send error: 40
src/client_side.cc