]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: usb: rtl8150: fix memory leak on usb_submit_urb() failure
authorDeepakkumar Karn <dkarn@redhat.com>
Tue, 16 Dec 2025 15:13:05 +0000 (20:43 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Jan 2026 12:11:53 +0000 (13:11 +0100)
commita4e2442d3c48355a84463342f397134f149936d7
tree15e82d4a5716003487a024d3cb20f2622eec55b3
parent25029e813c4aae5fcf7118e8dd5c56e382b9a1a3
net: usb: rtl8150: fix memory leak on usb_submit_urb() failure

[ Upstream commit 12cab1191d9890097171156d06bfa8d31f1e39c8 ]

In async_set_registers(), when usb_submit_urb() fails, the allocated
  async_req structure and URB are not freed, causing a memory leak.

  The completion callback async_set_reg_cb() is responsible for freeing
  these allocations, but it is only called after the URB is successfully
  submitted and completes (successfully or with error). If submission
  fails, the callback never runs and the memory is leaked.

  Fix this by freeing both the URB and the request structure in the error
  path when usb_submit_urb() fails.

Reported-by: syzbot+8dd915c7cb0490fc8c52@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=8dd915c7cb0490fc8c52
Fixes: 4d12997a9bb3 ("drivers: net: usb: rtl8150: concurrent URB bugfix")
Signed-off-by: Deepakkumar Karn <dkarn@redhat.com>
Link: https://patch.msgid.link/20251216151304.59865-2-dkarn@redhat.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/usb/rtl8150.c