]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Begin fixing uses of strtol: parse integers more carefully.
authorDaniel Veillard <veillard@redhat.com>
Mon, 12 Nov 2007 14:00:32 +0000 (14:00 +0000)
committerDaniel Veillard <veillard@redhat.com>
Mon, 12 Nov 2007 14:00:32 +0000 (14:00 +0000)
commita500a479b09d0906f4a3e3f6c1e8071818b521eb
tree9001c4cfe1eb8a9f688fb86063bce626cedc5af4
parent906c1f5055bfe8c4bf709525dcfdf99736ab473c
Begin fixing uses of strtol: parse integers more carefully.
Patch from Jim Meyering
* src/internal.h: Include <errno.h>.
  Define new static inline function, xstrtol_i.
* src/virsh.c: Detect integer overflow in domain ID number
  in vshCommandOptDomainBy. Detect overflow and invalid port
  number suffix in cmdVNCDisplay.
* src/xend_internal.c: Parse CPU number more carefully in
  xenDaemonDomainGetVcpus.
* tests/int-overflow: New script. Test for the above-fixed bug.
* tests/Makefile.am: Add int-overflow to TESTS. Define
  TESTS_ENVIRONMENT, to propagate $abs_top_* variables into the
  int-overflow script. Adapt the "valgrind" rule not to clobber
  new TESTS_ENVIRONMENT.
Daniel
ChangeLog
src/internal.h
src/virsh.c
src/xen_internal.c
src/xend_internal.c
src/xs_internal.c
tests/Makefile.am