]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
iommu/amd/iommu_v2: Fix pasid_state refcount dec hit 0 warning on pasid unbind
authorDaniel Marcovitch <dmarcovitch@nvidia.com>
Fri, 9 Jun 2023 10:51:45 +0000 (10:51 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Sep 2023 10:22:43 +0000 (12:22 +0200)
commita50d60b8f2aff46dd7c7edb4a5835cdc4d432c22
treef626c37d4381841552ba45cc74c260680b518e30
parentcaf058833b6f3fe7beabf738110f79bb987c8fff
iommu/amd/iommu_v2: Fix pasid_state refcount dec hit 0 warning on pasid unbind

[ Upstream commit 534103bcd52ca9c1fecbc70e717b4a538dc4ded8 ]

When unbinding pasid - a race condition exists vs outstanding page faults.

To prevent this, the pasid_state object contains a refcount.
    * set to 1 on pasid bind
    * incremented on each ppr notification start
    * decremented on each ppr notification done
    * decremented on pasid unbind

Since refcount_dec assumes that refcount will never reach 0:
  the current implementation causes the following to be invoked on
  pasid unbind:
        REFCOUNT_WARN("decrement hit 0; leaking memory")

Fix this issue by changing refcount_dec to refcount_dec_and_test
to explicitly handle refcount=1.

Fixes: 8bc54824da4e ("iommu/amd: Convert from atomic_t to refcount_t on pasid_state->count")
Signed-off-by: Daniel Marcovitch <dmarcovitch@nvidia.com>
Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
Link: https://lore.kernel.org/r/20230609105146.7773-2-vasant.hegde@amd.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/iommu/amd/iommu_v2.c