]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: dsa: dsa_loop: use int type to store negative error codes
authorQianfeng Rong <rongqianfeng@vivo.com>
Wed, 3 Sep 2025 12:34:03 +0000 (20:34 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 4 Sep 2025 14:26:44 +0000 (07:26 -0700)
commita50e7864ca44f519935cdb04796c714eb9d6670c
treef24f4fad1f1018cdbd8afe098788d0a886bb2c02
parent3cd4c4f3955bd97470cc8728c28327cffb09f71e
net: dsa: dsa_loop: use int type to store negative error codes

Change the 'ret' variable in dsa_loop_init() from unsigned int to int, as
it needs to store either negative error codes or zero returned by
mdio_driver_register().

Storing the negative error codes in unsigned type, doesn't cause an issue
at runtime but can be confusing.  Additionally, assigning negative error
codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
flag is enabled.

No effect on runtime.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Link: https://patch.msgid.link/20250903123404.395946-1-rongqianfeng@vivo.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/dsa_loop.c