]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: gp8psk: initialize stats at power control logic
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 27 Nov 2020 06:40:21 +0000 (07:40 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 9 Jan 2021 12:35:49 +0000 (13:35 +0100)
commita51a49bc55ee46eaa0cc8da9896100da403b5541
treed181bbff9d827786d28adba03b0460406259653d
parent6bfac5d605c7d5b22b08900a35220769ce4bc696
media: gp8psk: initialize stats at power control logic

commit d0ac1a26ed5943127cb0156148735f5f52a07075 upstream.

As reported on:
https://lore.kernel.org/linux-media/20190627222020.45909-1-willemdebruijn.kernel@gmail.com/

if gp8psk_usb_in_op() returns an error, the status var is not
initialized. Yet, this var is used later on, in order to
identify:
- if the device was already started;
- if firmware has loaded;
- if the LNBf was powered on.

Using status = 0 seems to ensure that everything will be
properly powered up.

So, instead of the proposed solution, let's just set
status = 0.

Reported-by: syzbot <syzkaller@googlegroups.com>
Reported-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/usb/dvb-usb/gp8psk.c