]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Do not emit WAL for unlogged BRIN indexes
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 18 Dec 2025 13:08:48 +0000 (15:08 +0200)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 18 Dec 2025 13:09:21 +0000 (15:09 +0200)
commita5277700e47862e9f83b0695fb34ffff0ea2fa34
treee83d79562928c524f63d3d3e6c2f5d8578adf325
parent2655d2e47803f9075dd6354f7c317037f2c32e8f
Do not emit WAL for unlogged BRIN indexes

Operations on unlogged relations should not be WAL-logged. The
brin_initialize_empty_new_buffer() function didn't get the memo.

The function is only called when a concurrent update to a brin page
uses up space that we're just about to insert to, which makes it
pretty hard to hit. If you do manage to hit it, a full-page WAL record
is erroneously emitted for the unlogged index. If you then crash,
crash recovery will fail on that record with an error like this:

    FATAL:  could not create file "base/5/32819": File exists

Author: Kirill Reshke <reshkekirill@gmail.com>
Discussion: https://www.postgresql.org/message-id/CALdSSPhpZXVFnWjwEBNcySx_vXtXHwB2g99gE6rK0uRJm-3GgQ@mail.gmail.com
Backpatch-through: 14
src/backend/access/brin/brin_pageops.c