]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/amd/pm/powerplay/hwmgr/smu_helper: fix order of mask and value
authorFedor Pchelkin <pchelkin@ispras.ru>
Mon, 30 Jun 2025 20:26:17 +0000 (23:26 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 7 Jul 2025 17:47:02 +0000 (13:47 -0400)
commita54e4639c4ef37a0241bac7d2a77f2e6ffb57099
tree4f4b2b54da3697af54f127fb3c2edb18c5099b03
parent14b2d71a9a24727f1b9f2131ed5eb2e345840a3a
drm/amd/pm/powerplay/hwmgr/smu_helper: fix order of mask and value

There is a small typo in phm_wait_on_indirect_register().

Swap mask and value arguments provided to phm_wait_on_register() so that
they satisfy the function signature and actual usage scheme.

Found by Linux Verification Center (linuxtesting.org) with Svace static
analysis tool.

In practice this doesn't fix any issues because the only place this
function is used uses the same value for the value and mask.

Fixes: 3bace3591493 ("drm/amd/powerplay: add hardware manager sub-component")
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu_helper.c