]> git.ipfire.org Git - thirdparty/libvirt.git/commit
src: reject empty string for 'dname' in migrate APIs
authorDaniel P. Berrangé <berrange@redhat.com>
Wed, 8 Nov 2023 16:20:35 +0000 (16:20 +0000)
committerDaniel P. Berrangé <berrange@redhat.com>
Tue, 21 Nov 2023 17:35:56 +0000 (17:35 +0000)
commita585ef905aa5633b20a76ca87fbd0d52a5f4aba4
tree4e206467cfa5e280f4b81395d18ec1729c19c3b0
parent66e84b8a953c59d7248f62d514957cec61515eb7
src: reject empty string for 'dname' in migrate APIs

A domain name is expected to be non-empty, and we validate this when
parsing XML, or accepting a new name during renames. We fail to
enforce this property, however, when performing a migration. This
was discovered when a user complained about inaccessible VMs after
migrating with the Rust APIs which mistakenly hardcoded 'dname' to
the empty string.

Fixes: https://gitlab.com/libvirt/libvirt-rust/-/issues/11
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
src/internal.h
src/libvirt-domain.c