]> git.ipfire.org Git - thirdparty/git.git/commit
tree-diff: drop list-tail argument to diff_tree_paths()
authorJeff King <peff@peff.net>
Thu, 9 Jan 2025 08:51:56 +0000 (03:51 -0500)
committerJunio C Hamano <gitster@pobox.com>
Thu, 9 Jan 2025 20:24:26 +0000 (12:24 -0800)
commita5c4e31af9b8b8fb362472ce3a1ec404df0da032
treeeb85a78b9ae939ae6cc47a0c37ad33dc2ae2f61f
parent69f6dea44cf272dc80be6dffd0ac8db5c50585b4
tree-diff: drop list-tail argument to diff_tree_paths()

The internals of the path diffing code, including ll_diff_tree_paths(),
all take an extra combine_diff_path parameter which they use as the tail
of a list of results, appending any new entries to it.

The public-facing diff_tree_paths() takes the same argument, but it just
makes the callers more awkward. They always start with a clean list, and
have to set up a fake head struct to pass in.

Let's keep the public API clean by always returning a new list. That
keeps the fake struct as an implementation detail of tree-diff.c.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
combine-diff.c
diff.h
tree-diff.c