]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
[3.7] bpo-34872: Fix self-cancellation in C implementation of asyncio.Task (GH-9679...
authorElvis Pranskevichus <elvis@magic.io>
Wed, 3 Oct 2018 15:49:00 +0000 (11:49 -0400)
committerMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Wed, 3 Oct 2018 15:49:00 +0000 (08:49 -0700)
commita67bd53d3f80ac9c518b5426aa35459bd373b2b3
treeabe411bae972f961a257f94d19e7ba4e2d03a071
parent063755c20184e80f587d522600536d1ba70a5f7e
[3.7] bpo-34872: Fix self-cancellation in C implementation of asyncio.Task (GH-9679) (GH-9691)

The C implementation of asyncio.Task currently fails to perform the
cancellation cleanup correctly in the following scenario.

    async def task1():
        async def task2():
            await task3     # task3 is never cancelled

        asyncio.current_task().cancel()
        await asyncio.create_task(task2())

The actuall error is a hardcoded call to `future_cancel()` instead of
calling the `cancel()` method of a future-like object.

Thanks to Vladimir Matveev for noticing the code discrepancy and to
Yury Selivanov for coming up with a pathological scenario..
(cherry picked from commit 548ce9dedd2e90945970671d441436a6a91608ab)

Co-authored-by: Elvis Pranskevichus <elvis@magic.io>
https://bugs.python.org/issue34872
Lib/test/test_asyncio/test_tasks.py
Misc/NEWS.d/next/Library/2018-10-02-19-36-34.bpo-34872.yWZRhI.rst [new file with mode: 0644]
Modules/_asynciomodule.c