]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
cgroup: Fix potential overflow issue when checking max_depth
authorXiu Jianfeng <xiujianfeng@huawei.com>
Sat, 12 Oct 2024 07:22:46 +0000 (07:22 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Nov 2024 15:25:51 +0000 (16:25 +0100)
commita69d18e8029d76d7095b12812bdc75655d99f012
tree48c7be100f2901ecfc4c9045cd1c670f0ff4410d
parent8df52929530839e878e6912e33348b54101e3250
cgroup: Fix potential overflow issue when checking max_depth

[ Upstream commit 3cc4e13bb1617f6a13e5e6882465984148743cf4 ]

cgroup.max.depth is the maximum allowed descent depth below the current
cgroup. If the actual descent depth is equal or larger, an attempt to
create a new child cgroup will fail. However due to the cgroup->max_depth
is of int type and having the default value INT_MAX, the condition
'level > cgroup->max_depth' will never be satisfied, and it will cause
an overflow of the level after it reaches to INT_MAX.

Fix it by starting the level from 0 and using '>=' instead.

It's worth mentioning that this issue is unlikely to occur in reality,
as it's impossible to have a depth of INT_MAX hierarchy, but should be
be avoided logically.

Fixes: 1a926e0bbab8 ("cgroup: implement hierarchy limits")
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Reviewed-by: Michal Koutný <mkoutny@suse.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/cgroup/cgroup.c