]> git.ipfire.org Git - thirdparty/knot-resolver.git/commit
nsrep: never blacklist NSs because of SERVFAIL/REFUSED
authorMarek Vavruša <mvavrusa@cloudflare.com>
Thu, 12 Apr 2018 08:35:50 +0000 (01:35 -0700)
committerMarek Vavruša <mvavrusa@cloudflare.com>
Fri, 7 Sep 2018 17:45:21 +0000 (10:45 -0700)
commita6b6a917736faabea1a0d8ea2277f00d8be78ce8
tree0f61b509e9bebbf68f5dd47d55d09965cca9e396
parent1430099f6d005f741914eb32adba60ec4850834e
nsrep: never blacklist NSs because of SERVFAIL/REFUSED

The SERVFAIL is a soft-failure, and REFUSED isn't something the server
is really in control of. It is easy to trick the resolver into blacklisting
a NS by creating a bad delegation and pointing it at the victim NS.

This changes the scoring function to degrade server score on these rcodes,
but cap it to a really bad score. It should be treated as timed out only
if it really times out or is unreachable.
lib/nsrep.c
lib/resolve.c