]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
netfilter: nf_conntrack_h323: don't pass uninitialised l3num value
authorFlorian Westphal <fw@strlen.de>
Wed, 11 Feb 2026 11:53:09 +0000 (12:53 +0100)
committerFlorian Westphal <fw@strlen.de>
Tue, 17 Feb 2026 14:04:20 +0000 (15:04 +0100)
commita6d28eb8efe96b3e35c92efdf1bfacb0cccf541f
treef19d178c2434d859ca2b8ac065c9d6a1be2637b5
parent7f261bb906bf527c4a6e2a646e2d5f3679f2a8bc
netfilter: nf_conntrack_h323: don't pass uninitialised l3num value

Mihail Milev reports: Error: UNINIT (CWE-457):
 net/netfilter/nf_conntrack_h323_main.c:1189:2: var_decl:
Declaring variable "tuple" without initializer.
 net/netfilter/nf_conntrack_h323_main.c:1197:2:
uninit_use_in_call: Using uninitialized value "tuple.src.l3num" when calling "__nf_ct_expect_find".
 net/netfilter/nf_conntrack_expect.c:142:2:
read_value: Reading value "tuple->src.l3num" when calling "nf_ct_expect_dst_hash".

  1195|    tuple.dst.protonum = IPPROTO_TCP;
  1196|
  1197|->  exp = __nf_ct_expect_find(net, nf_ct_zone(ct), &tuple);
  1198|    if (exp && exp->master == ct)
  1199|    return exp;

Switch this to a C99 initialiser and set the l3num value.

Fixes: f587de0e2feb ("[NETFILTER]: nf_conntrack/nf_nat: add H.323 helper port")
Signed-off-by: Florian Westphal <fw@strlen.de>
net/netfilter/nf_conntrack_h323_main.c