]> git.ipfire.org Git - thirdparty/linux.git/commit
mei: Fix error handling in mei_register
authorMa Ke <make24@iscas.ac.cn>
Tue, 4 Nov 2025 02:01:33 +0000 (10:01 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Nov 2025 12:31:44 +0000 (13:31 +0100)
commita6dab2f61d23c1eb32f1d08fa7b4919a2478950b
tree9b4285678e227da4beafc74d6689f9dcaa591dc8
parent5d92c3b41f0bddfa416130c6e1b424414f3d2acf
mei: Fix error handling in mei_register

mei_register() fails to release the device reference in error paths
after device_initialize(). During normal device registration, the
reference is properly handled through mei_deregister() which calls
device_destroy(). However, in error handling paths (such as cdev_alloc
failure, cdev_add failure, etc.), missing put_device() calls cause
reference count leaks, preventing the device's release function
(mei_device_release) from being called and resulting in memory leaks
of mei_device.

Found by code review.

Cc: stable <stable@kernel.org>
Fixes: 7704e6be4ed2 ("mei: hook mei_device on class device")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Acked-by: Alexander Usyskin <alexander.usyskin@intel.com>
Link: https://patch.msgid.link/20251104020133.5017-1-make24@iscas.ac.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mei/main.c