]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix running out of file descriptors for spill files.
authorAmit Kapila <akapila@postgresql.org>
Thu, 2 Jan 2020 06:58:02 +0000 (12:28 +0530)
committerAmit Kapila <akapila@postgresql.org>
Thu, 2 Jan 2020 06:58:02 +0000 (12:28 +0530)
commita6f4f407ada026007d37ab9d494bb6380ec12527
tree0fcecb4b07a178a9540c1fec4e3ab8d244bf840a
parent78b381c5ddadb25e915ee4f380c28a676851998c
Fix running out of file descriptors for spill files.

Currently while decoding changes, if the number of changes exceeds a
certain threshold, we spill those to disk.  And this happens for each
(sub)transaction.  Now, while reading all these files, we don't close them
until we read all the files.  While reading these files, if the number of
such files exceeds the maximum number of file descriptors, the operation
errors out.

Use PathNameOpenFile interface to open these files as that internally has
the mechanism to release kernel FDs as needed to get us under the
max_safe_fds limit.

Reported-by: Amit Khandekar
Author: Amit Khandekar
Reviewed-by: Amit Kapila
Backpatch-through: 9.4
Discussion: https://postgr.es/m/CAJ3gD9c-sECEn79zXw4yBnBdOttacoE-6gAyP0oy60nfs_sabQ@mail.gmail.com
src/backend/replication/logical/reorderbuffer.c