]> git.ipfire.org Git - thirdparty/lxc.git/commit
utils: Copying source filename to avoid missing info. 3134/head
authorJulio Faracco <jcfaracco@gmail.com>
Thu, 5 Sep 2019 04:43:21 +0000 (01:43 -0300)
committerJulio Faracco <jcfaracco@gmail.com>
Thu, 5 Sep 2019 20:52:17 +0000 (17:52 -0300)
commita70c9e85a6d8ac1b75d6705d2373fd9c7b567240
tree6d2033d56c5af4c7264ab1ef2ca1f6207559c0cc
parent13a885dd104917f040c5091c383f745e6595cc88
utils: Copying source filename to avoid missing info.

Some applications use information from LOOP_GET_STATUS64. The file
associated with loop device is pointed inside structure field
`lo_file_name`. The current code is setting up a loop device without
this information. A legacy example of code checking this is cryptsetup:

    static char *_ioctl_backing_file(const char *loop)
    {
        struct loop_info64 lo64 = {0};
        int loop_fd;

        loop_fd = open(loop, O_RDONLY);
        if (loop_fd < 0)
            return NULL;

        if (ioctl(loop_fd, LOOP_GET_STATUS64, &lo64) < 0) {
            close(loop_fd);
            return NULL;
        }

        lo64.lo_file_name[LO_NAME_SIZE-2] = '*';
        lo64.lo_file_name[LO_NAME_SIZE-1] = 0;

        close(loop_fd);
        return strdup((char*)lo64.lo_file_name);
    }

It will return an empty string because lo_file_name was not set.

Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
src/lxc/utils.c