]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: fix __netdev_update_features return on ndo_set_features failure
authorNikolay Aleksandrov <nikolay@cumulusnetworks.com>
Fri, 13 Nov 2015 14:20:24 +0000 (15:20 +0100)
committerZefan Li <lizefan@huawei.com>
Wed, 26 Oct 2016 15:15:29 +0000 (23:15 +0800)
commita73cb24083e4068c8a7b7de4820e4906f78651b8
tree80362dd610676ba64ca43f040fbaebe478ffcad1
parentf4ea18fe5670fd16215344eaf3f7bfd7f19e0012
net: fix __netdev_update_features return on ndo_set_features failure

commit 00ee5927177792a6e139d50b6b7564d35705556a upstream.

If ndo_set_features fails __netdev_update_features() will return -1 but
this is wrong because it is expected to return 0 if no features were
changed (see netdev_update_features()), which will cause a netdev
notifier to be called without any actual changes. Fix this by returning
0 if ndo_set_features fails.

Fixes: 6cb6a27c45ce ("net: Call netdev_features_change() from netdev_update_features()")
CC: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Zefan Li <lizefan@huawei.com>
net/core/dev.c