]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: call cgroup_sk_alloc() earlier in sk_clone_lock()
authorEric Dumazet <edumazet@google.com>
Wed, 11 Oct 2017 02:12:33 +0000 (19:12 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 18 Nov 2017 10:30:35 +0000 (11:30 +0100)
commita74512a1739dfaee2397356451adf53b40798a94
tree832d261355bfdf1894bdd2bd48061a645c90a9a7
parentad1263b5ac01b65db6f9af996550be771dc9581f
net: call cgroup_sk_alloc() earlier in sk_clone_lock()

[ Upstream commit c0576e3975084d4699b7bfef578613fb8e1144f6 ]

If for some reason, the newly allocated child need to be freed,
we will call cgroup_put() (via sk_free_unlock_clone()) while the
corresponding cgroup_get() was not yet done, and we will free memory
too soon.

Fixes: d979a39d7242 ("cgroup: duplicate cgroup reference when cloning sockets")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/core/sock.c