]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
NFC: fix attrs checks in netlink interface
authorAndrey Konovalov <andreyknvl@google.com>
Mon, 29 Jul 2019 13:35:01 +0000 (16:35 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 7 Oct 2019 16:59:40 +0000 (18:59 +0200)
commita761ba7254776e62e1420beb3ffc501ffd7f3a29
tree99e428b06e1a772bef91ab8fd0dece9c9e944f7d
parent08519f370a57fb9b2480e8af7449a7c1c22f96a5
NFC: fix attrs checks in netlink interface

commit 18917d51472fe3b126a3a8f756c6b18085eb8130 upstream.

nfc_genl_deactivate_target() relies on the NFC_ATTR_TARGET_INDEX
attribute being present, but doesn't check whether it is actually
provided by the user. Same goes for nfc_genl_fw_download() and
NFC_ATTR_FIRMWARE_NAME.

This patch adds appropriate checks.

Found with syzkaller.

Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/nfc/netlink.c