]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
f2fs: fix to wait on page writeback in __clone_blkaddrs()
authorChao Yu <chao@kernel.org>
Tue, 26 Mar 2024 11:28:45 +0000 (19:28 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 16 Jun 2024 11:39:34 +0000 (13:39 +0200)
commita762959a6f434f2990a4d9ed9aa90b2aaa1298f5
tree1968c1c60d1812f9569a578d40f0ebbfeaff5723
parentaaac91468f5b6757f72f30464bcf4489a75846e6
f2fs: fix to wait on page writeback in __clone_blkaddrs()

[ Upstream commit d3876e34e7e789e2cbdd782360fef2a777391082 ]

In below race condition, dst page may become writeback status
in __clone_blkaddrs(), it needs to wait writeback before update,
fix it.

Thread A GC Thread
- f2fs_move_file_range
  - filemap_write_and_wait_range(dst)
- gc_data_segment
 - f2fs_down_write(dst)
 - move_data_page
  - set_page_writeback(dst_page)
  - f2fs_submit_page_write
 - f2fs_up_write(dst)
  - f2fs_down_write(dst)
  - __exchange_data_block
   - __clone_blkaddrs
    - f2fs_get_new_data_page
    - memcpy_page

Fixes: 0a2aa8fbb969 ("f2fs: refactor __exchange_data_block for speed up")
Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/f2fs/file.c