]> git.ipfire.org Git - thirdparty/linux.git/commit
lib/crypto: x86/blake2s: Improve readability
authorEric Biggers <ebiggers@kernel.org>
Sun, 2 Nov 2025 23:42:07 +0000 (15:42 -0800)
committerEric Biggers <ebiggers@kernel.org>
Thu, 6 Nov 2025 04:30:52 +0000 (20:30 -0800)
commita7acd77ebd7f17b07a6ab2ca1dd1e4d487bdfa80
tree88509831eb6dc2fa97dfdcee2ec9e8f9047a3a15
parent83c1a867c9999b3bb83e3da8f22eec9ec77a523c
lib/crypto: x86/blake2s: Improve readability

Various cleanups for readability.  No change to the generated code:

- Add some comments
- Add #defines for arguments
- Rename some labels
- Use decimal constants instead of hex where it makes sense.
  (The pshufd immediates intentionally remain as hex.)
- Add blank lines when there's a logical break

The round loop still could use some work, but this is at least a start.

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/20251102234209.62133-5-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
lib/crypto/x86/blake2s-core.S