]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
flowcache: Fix kernel panic in flow_cache_flush_task
authorMiroslav Urbanek <mu@miroslavurbanek.com>
Thu, 5 Feb 2015 15:36:50 +0000 (16:36 +0100)
committerSasha Levin <sasha.levin@oracle.com>
Sat, 14 Mar 2015 19:37:09 +0000 (15:37 -0400)
commita7dc52c774f1cc83dcfeca3a3d0434f528473972
tree7a9ba5c9daad2fc57a90590fb52f67ac1bccd9d5
parentd1034e83796a0433194f67c2a8c4abf0f6138b01
flowcache: Fix kernel panic in flow_cache_flush_task

[ Upstream commit 233c96fc077d310772375d47522fb444ff546905 ]

flow_cache_flush_task references a structure member flow_cache_gc_work
where it should reference flow_cache_flush_task instead.

Kernel panic occurs on kernels using IPsec during XFRM garbage
collection. The garbage collection interval can be shortened using the
following sysctl settings:

net.ipv4.xfrm4_gc_thresh=4
net.ipv6.xfrm6_gc_thresh=4

With the default settings, our productions servers crash approximately
once a week. With the settings above, they crash immediately.

Fixes: ca925cf1534e ("flowcache: Make flow cache name space aware")
Reported-by: Tomáš Charvát <tc@excello.cz>
Tested-by: Jan Hejl <jh@excello.cz>
Signed-off-by: Miroslav Urbanek <mu@miroslavurbanek.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
net/core/flow.c