]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
pwm: Fix double shift bug
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 25 Oct 2023 11:58:18 +0000 (14:58 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 28 Nov 2023 16:56:21 +0000 (16:56 +0000)
commita7ee519e8095d9c834086d0ff40da11415e1e4d7
tree1abf815a334809844bfd10d8285bd71e25b4298b
parent7054366cd0764735b429031fd59fceff817e21c7
pwm: Fix double shift bug

[ Upstream commit d27abbfd4888d79dd24baf50e774631046ac4732 ]

These enums are passed to set/test_bit().  The set/test_bit() functions
take a bit number instead of a shifted value.  Passing a shifted value
is a double shift bug like doing BIT(BIT(1)).  The double shift bug
doesn't cause a problem here because we are only checking 0 and 1 but
if the value was 5 or above then it can lead to a buffer overflow.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/linux/pwm.h