]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
livepatch: Nullify obj->mod in klp_module_coming()'s error path
authorMiroslav Benes <mbenes@suse.cz>
Fri, 19 Jul 2019 12:28:39 +0000 (14:28 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 7 Oct 2019 16:59:28 +0000 (18:59 +0200)
commita7ef43bf90640761584ef7f618e99cd277167b91
tree4cdbfbc9bb375dfe55bade92d8d399939250e109
parent677540cb39e0ef8a845c5662458f6440b0e7050d
livepatch: Nullify obj->mod in klp_module_coming()'s error path

[ Upstream commit 4ff96fb52c6964ad42e0a878be8f86a2e8052ddd ]

klp_module_coming() is called for every module appearing in the system.
It sets obj->mod to a patched module for klp_object obj. Unfortunately
it leaves it set even if an error happens later in the function and the
patched module is not allowed to be loaded.

klp_is_object_loaded() uses obj->mod variable and could currently give a
wrong return value. The bug is probably harmless as of now.

Signed-off-by: Miroslav Benes <mbenes@suse.cz>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/livepatch/core.c