]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
gdb/testsuite: add return after a call to 'untested'
authorAndrew Burgess <aburgess@redhat.com>
Sat, 10 Aug 2024 11:26:49 +0000 (12:26 +0100)
committerAndrew Burgess <aburgess@redhat.com>
Tue, 10 Sep 2024 14:11:05 +0000 (15:11 +0100)
commita80935397a191dcf87ab19a0bae5c74c87a263e9
treea25f23741e0e0c2a145358340bbc544b834ae150
parent523b8f4f29ef79032f850b7189765d815a59a330
gdb/testsuite: add return after a call to 'untested'

In gdb.base/corefile-buildid.exp, in the function
do_corefile_buildid_tests, if we fail to find the build-id for the
test binary then we call 'untested', but then push on with the test,
which inevitably fails as the rest of the test depends on having found
the build-id.

I think we're missing a 'return' after the call to 'untested' which
I've now added.

Also I noticed that we call build_id_debug_filename_get and then
manually remove '.debug' from the end.  This is no longer necessary,
we can just ask build_id_debug_filename_get to not add the suffix.
gdb/testsuite/gdb.base/corefile-buildid.exp