]> git.ipfire.org Git - thirdparty/libvirt.git/commit
admin: Use the connection to determine a client is connected readonly
authorErik Skultety <eskultet@redhat.com>
Wed, 13 Dec 2017 13:39:40 +0000 (14:39 +0100)
committerErik Skultety <eskultet@redhat.com>
Mon, 18 Dec 2017 07:42:29 +0000 (08:42 +0100)
commita8582e3656d626a0728bbbfb4fd715aa51676522
tree8838c0507d0a19f96d9765dbb27fd030d4e9eb8a
parent69ed99c78696d7ac405ce9e193a4a312fd9945d7
admin: Use the connection to determine a client is connected readonly

Prior to this change, we relied solely on the inherited readonly
attribute of a service's socket. This only worked for our UNIX sockets
(and only to some degree), but doesn't work for TCP sockets which are RW
by default, but such connections support RO as well. This patch forces
an update on the client object once we have established a connection to
reflect the nature of the connection itself rather than relying on the
underlying socket's attributes.
Clients connected to the admin server have always been connected as RW
only.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1524399
Signed-off-by: Erik Skultety <eskultet@redhat.com>
daemon/remote.c
src/libvirt_remote.syms
src/rpc/virnetserverclient.c
src/rpc/virnetserverclient.h