]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drivers: media: dvb-frontends/rtl2832: fix an out-of-bounds write error
authorJunlin Li <make24@iscas.ac.cn>
Tue, 2 Jul 2024 13:24:13 +0000 (21:24 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Oct 2024 13:11:00 +0000 (15:11 +0200)
commita879b6cdd48134a3d58949ea4f075c75fa2d7d71
tree2c41b8aa4284dc90cdbbb8a6ebe698c13d82cf1a
parent9a2d7636af44724d77fb3ab8923ab70fb73795c9
drivers: media: dvb-frontends/rtl2832: fix an out-of-bounds write error

[ Upstream commit 8ae06f360cfaca2b88b98ca89144548b3186aab1 ]

Ensure index in rtl2832_pid_filter does not exceed 31 to prevent
out-of-bounds access.

dev->filters is a 32-bit value, so set_bit and clear_bit functions should
only operate on indices from 0 to 31. If index is 32, it will attempt to
access a non-existent 33rd bit, leading to out-of-bounds access.
Change the boundary check from index > 32 to index >= 32 to resolve this
issue.

Signed-off-by: Junlin Li <make24@iscas.ac.cn>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Fixes: 4b01e01a81b6 ("[media] rtl2832: implement PID filter")
[hverkuil: added fixes tag, rtl2830_pid_filter -> rtl2832_pid_filter in logmsg]
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/dvb-frontends/rtl2832.c