]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
sched/fair: Fix overutilized update in enqueue_task_fair()
authorQuentin Perret <qperret@google.com>
Thu, 12 Nov 2020 11:12:01 +0000 (11:12 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Nov 2020 12:29:24 +0000 (13:29 +0100)
commita88f08e78249f5979101684a3afd4aff5dec59e7
tree33d82bb21e726d8c0ee6c14f062c328101d4228c
parent10ca291c774924998dadbf001bebc4ef16c096d9
sched/fair: Fix overutilized update in enqueue_task_fair()

commit 8e1ac4299a6e8726de42310d9c1379f188140c71 upstream.

enqueue_task_fair() attempts to skip the overutilized update for new
tasks as their util_avg is not accurate yet. However, the flag we check
to do so is overwritten earlier on in the function, which makes the
condition pretty much a nop.

Fix this by saving the flag early on.

Fixes: 2802bf3cd936 ("sched/fair: Add over-utilization/tipping point indicator")
Reported-by: Rick Yiu <rickyiu@google.com>
Signed-off-by: Quentin Perret <qperret@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
Link: https://lkml.kernel.org/r/20201112111201.2081902-1-qperret@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/sched/fair.c