]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
hwmon: (gpd-fan): Initialize EC before registering hwmon device
authorPei Xiao <xiaopei01@kylinos.cn>
Wed, 10 Jun 2026 01:49:10 +0000 (09:49 +0800)
committerGuenter Roeck <linux@roeck-us.net>
Wed, 10 Jun 2026 13:13:47 +0000 (06:13 -0700)
commita8a444917fe5d30a9787f41cc179f55fc5f559d3
tree409708380decd5ad332e5ca93a48b9180b03c8f9
parent03b4addf8282fa2b63f2d7448d1a9bce9be3f556
hwmon: (gpd-fan): Initialize EC before registering hwmon device

Move the gpd_init_ec() call to before devm_hwmon_device_register_with_info
in the probe function. With the previous ordering the hwmon device was
registered and exposed to userspace before the EC initialization
completes, creating a window where sysfs reads could return invalid values.

Some buggy firmware won't initialize EC properly on boot. Before its
initialization, reading RPM will always return 0, and writing PWM will have
no effect. So move gpd_init_ec to before hwmon device register.

Fixes: 0ab88e239439 ("hwmon: add GPD devices sensor driver")
Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
Link: https://lore.kernel.org/r/4be3734b135c8013157979ab5e80c7ee51243ddd.1781055639.git.xiaopei01@kylinos.cn
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/gpd-fan.c