]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net/sched: sch_red: annotate data-races in red_dump_stats()
authorEric Dumazet <edumazet@google.com>
Tue, 21 Apr 2026 14:23:09 +0000 (14:23 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 23 Apr 2026 04:12:54 +0000 (21:12 -0700)
commita8f5192809caf636d05ba47c144f282cfd0e3839
tree66f8b643305bc993146598652322debdfadff280
parentbbfaa73ea6871db03dc05d7f05f00557a8981f25
net/sched: sch_red: annotate data-races in red_dump_stats()

red_dump_stats() only runs with RTNL held,
reading fields that can be changed in qdisc fast path.

Add READ_ONCE()/WRITE_ONCE() annotations.

Alternative would be to acquire the qdisc spinlock, but our long-term
goal is to make qdisc dump operations lockless as much as we can.

tc_red_xstats fields don't need to be latched atomically,
otherwise this bug would have been caught earlier.

Fixes: edb09eb17ed8 ("net: sched: do not acquire qdisc spinlock in qdisc/class stats dump")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
Link: https://patch.msgid.link/20260421142309.3964322-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sched/sch_red.c